fix(remote): define special variables behavior#2847
Merged
Conversation
Issue #2267 — Define semantics of file-path special variables when the Taskfile is loaded from a remote source (HTTP/HTTPS/Git): - TASKFILE / ROOT_TASKFILE: raw URL (fixes the broken `https:/...` caused by filepath.Join collapsing the double slash) - TASKFILE_DIR / ROOT_DIR: empty string — a DIR variable cannot point to a URL - TASK_DIR: resolved against USER_WORKING_DIR Export taskfile.IsRemoteEntrypoint so the compiler can dispatch on the nature of the entrypoint without relying on `c.Dir == ""` (a side effect of the remote path).
The behavior is already documented in experiments/remote-taskfiles.md and validated by the table-driven test.
Build paths from t.TempDir() so they are valid absolute paths on Windows too (filepath.IsAbs treats `/abs/path` as non-absolute there).
vmaerten
marked this pull request as ready for review
May 18, 2026 16:53
pd93
approved these changes
Jun 29, 2026
pd93
added a commit
that referenced
this pull request
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2267.
Defines the semantics of file-path special variables when a Taskfile is loaded from a remote source (HTTP/HTTPS/Git):
TASKFILE/ROOT_TASKFILETASKFILE_DIR/ROOT_DIRfilepath.Dir(...)""(a DIR cannot point to a URL)TASK_DIRSmartJoin(c.Dir, task.dir)USER_WORKING_DIRThis fixes the broken outputs reported in the issue (
ROOT_TASKFILE: https:/taskfile.devwith one slash missing,TASKFILE_DIR: https:, emptyROOT_DIR/TASK_DIR) by no longer applyingfilepath.Dir/filepath.Jointo URLs.taskfile.isRemoteEntrypointis exported asIsRemoteEntrypointso the compiler can dispatch on the actual nature of the entrypoint instead of relying on the side-effectc.Dir == "".The
TASK_DIRrules in remote mode are:task.dirempty :USER_WORKING_DIRtask.dirabsolute : kept as-istask.dirrelative :SmartJoin(USER_WORKING_DIR, dir)