Revert "fix(windows): hide console window when spawning browser processes"#39994
Merged
Conversation
Contributor
Test results for "tests 1"6 flaky39108 passed, 846 skipped Merge workflow run. |
Contributor
Test results for "MCP"2 failed 6310 passed, 370 skipped Merge workflow run. |
dgozman
approved these changes
Apr 1, 2026
pavelfeldman
pushed a commit
that referenced
this pull request
Apr 1, 2026
…pawning browser processes"
Mike-E-Log
added a commit
to Mike-E-Log/gstack
that referenced
this pull request
Jun 9, 2026
…e flash Playwright's default headless launch uses chrome-headless-shell.exe, a console-subsystem (WINDOWS_CUI) binary. The browse server runs as a detached console-less daemon, so that spawn allocates a fresh VISIBLE console window on every browser cold start (the recurring "AppData\Loca..." popup; reported in garrytan#1835). Playwright will not set windowsHide in its launcher (an unconditional fix was reverted upstream for breaking the Inspector window, microsoft/playwright#39994), but the maintainers verified full chrome.exe is GUI-subsystem and its new headless mode never allocates a console (microsoft/playwright#40741). Add headlessLaunchChannel(): win32 headless launches opt into channel: 'chromium' (the full Chromium binary, installed by setup's `playwright install chromium`). Headed launches and other platforms keep Playwright's defaults. When the pinned revision's full Chromium is absent from the ms-playwright cache (e.g. only chromium_headless_shell-<rev> is installed), launchWithHeadlessChannelFallback() degrades to the default headless shell with a one-line install hint instead of failing — a console flash is annoying; a daemon that cannot launch a browser is broken. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #38776, closes #39990