add fill selection text for quick search#191956
Conversation
|
This is a simple version, there are still many problems to solve, i.e. if we select a word in the editor, but we switch the cursor to the left search window, and let the cursor in the input box, the shortcut search will still fill the editor selected word, I think it should not be filled at this time, so I will add judgment for editor is focus |
andreamah
left a comment
There was a problem hiding this comment.
Thanks again for working on this! Just some small comments.
andreamah
left a comment
There was a problem hiding this comment.
Thanks! just a few more nitpicks
These are all help to correct my code progress ~ |
andreamah
left a comment
There was a problem hiding this comment.
Apologies for not commenting on this earlier - I just noticed this while testing your PR.
This reverts commit 7014efc.
|
@TylerLeonhardt This PR looks fine to me, but I did notice that this doesn't work if vscode/src/vs/platform/quickinput/browser/quickAccess.ts Lines 83 to 87 in 26f41a4 Should we edit this somehow, or is this intentional? |
|
@andreamah that seems backwards to me. Can you get an issue going and I'll take a look deeper? |
|
Excited to see this land! Thanks, @weartist! |
For: #191513