src: replace idna functions with ada::idna#47735
Merged
Merged
Conversation
nodejs-github-bot
added
c++
jasnell
reviewed
Apr 26, 2023
jasnell
approved these changes
Apr 26, 2023
Co-authored-by: Daniel Lemire <daniel@lemire.me>
anonrig
added
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
29 tasks
JungMinu
approved these changes
Apr 28, 2023
anonrig
added
the
commit-queue
TimothyGu
reviewed
Apr 28, 2023
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 1123377 |
32 tasks
This was referenced Apr 30, 2023
33 tasks
This was referenced Jul 21, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47726
Co-authored-by: Daniel Lemire (@lemire)
cc @tniessen @nodejs/cpp-reviewers @nodejs/url