Inconsistent return type from click.getchar()

[pkch]

It seems that click.getchar() will return bytes under python 3 / Windows, and str under any other combination of python version and platform. Is this the intended behavior or a bug?

I wanted to update the stub for click but if it's a bug and can be fixed soon, I can leave the typeshed stub unchanged.

[ScottSturdivant]

The documentation states:

This will always return a unicode character

I've witnessed the same behavior (bytes w/Python3 and Windows, str elsewhere) and to me, this inconsistency is a bug.

[ScottSturdivant]

Can anyone see a reason for this PY2 guard here?

[kip-13]

The python 3 doc's is clear with this:

Read a keypress and return the resulting character as a byte string

In python 2 doc say this:

Read a keypress and return the resulting character

[JelleZijlstra]

Those are docs for the standard library, not for click.

[kip-13]

@JelleZijlstra I know, but if you see the code of getchar you understand why I mentioned the module msvcrt (Windows / Python 3.x use case)

[sirosen]

Closed by #1108