Option callbacks are now invoked inside prompt and can be used to validate prompt inputs#1785
Merged
Merged
Conversation
davidism
reviewed
Feb 16, 2021
davidism
force-pushed
the
sanitize-input
branch
from
February 24, 2021 21:27
5c52e28 to
8bcbe28
Compare
davidism
force-pushed
the
sanitize-input
branch
from
February 24, 2021 22:37
8bcbe28 to
05c38db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Callbacks used to be invoked for the prompt results, therefore couldn't be used as validators for validating prompt input. Following are the changes made -
Parameter.process_valueintoParameter.full_process_valuefull_process_valuetoprocess_valueif self.callbackblock fromhandle_parse_resultto the bottomprocess_valueThe current behaviour due to the above changes is as expected to be. The user will be prompted until he/she enters a value deemed valid by the validator callback.
However, this test is failing. From what I understand,
process_valuegets the value from the prompt whenvalueisNoneandself.promptisTrue. I think thatself.prompt_requiredneeds to be used somewhere but I'm not sure where exactly.I plan to update the docs, once all tests pass.
Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.