Deprecation notice now appears at the top of the help text#1816
Merged
Conversation
davidism
reviewed
Mar 24, 2021
Member
|
This should update |
BALaka-18
marked this pull request as draft
March 26, 2021 18:40
BALaka-18
marked this pull request as ready for review
March 28, 2021 22:33
davidism
reviewed
Mar 29, 2021
davidism
force-pushed
the
fix-deprecation-notice
branch
from
March 31, 2021 19:21
0010a05 to
77921aa
Compare
Co-authored-by: David Lord <davidism@gmail.com>
davidism
force-pushed
the
fix-deprecation-notice
branch
from
March 31, 2021 19:23
0fb55c5 to
0786fda
Compare
Member
|
Ended up doing some more refactoring to avoid some repetition. Added the deprecation notice when generating short help from help as well. Inlined the deprecation messages and made the notice title case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the deprecation notice appear at the beginning of the help text.
Checklist:
CHANGES.rstsummarizing the change and linking to the issue.pre-commithooks and fix any issues.pytestandtox, no tests failed.