refactor type_cast_value#1852
Merged
Merged
Conversation
default value is validated against multiple and nargs in __init__
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mutlipleandnargs.BadParameter, notTypeErrororValueError.defaultvalue againstmultipleandnargsin__init__. Can't usetype_cast_valueondefaultas that can have side effects such as opening a file.multipleandnargs=-1, validate that the value is iterable (and not a string). Fornargs>0validate that the length matches. Formultipleandnargs>0, validate the length of each item.types.Tuple.convert, raise aBadParametererror and match the argument count error that Python would raise.multiplea parameter forParameterinstead of onlyOption.Argumentchecks that it's not given.Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.