Skip to content

count help doesn't show default range type#2084

Merged
davidism merged 1 commit into
8.0.xfrom
count-type-help
Oct 7, 2021
Merged

count help doesn't show default range type#2084
davidism merged 1 commit into
8.0.xfrom
count-type-help

Conversation

@davidism

@davidism davidism commented Oct 7, 2021

Copy link
Copy Markdown
Member

Click 8 began showing help text for range types. A count option gets a default type of IntRange(min=0). If the type is IntRange but the option is count with this default type, the range help will not be shown. If a different range is used, it will still be shown.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@davidism davidism added this to the 8.0.2 milestone Oct 7, 2021
@davidism
davidism changed the base branch from main to 8.0.x October 7, 2021 14:05
@davidism davidism added the f:help feature: help text label Oct 7, 2021
@davidism davidism linked an issue Oct 7, 2021 that may be closed by this pull request
@davidism
davidism merged commit f74dbbb into 8.0.x Oct 7, 2021
@davidism
davidism deleted the count-type-help branch October 7, 2021 14:08
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

f:help feature: help text

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Help text for count options has [x>=0] appended

1 participant