Skip to content

Mark clearly functions private status. Deprecated Python 2 utilities.#3695

Merged
Rowlando13 merged 2 commits into
pallets:mainfrom
Rowlando13:deprecate_utils
Jul 17, 2026
Merged

Mark clearly functions private status. Deprecated Python 2 utilities.#3695
Rowlando13 merged 2 commits into
pallets:mainfrom
Rowlando13:deprecate_utils

Conversation

@Rowlando13

@Rowlando13 Rowlando13 commented Jul 16, 2026

Copy link
Copy Markdown
Member

Closes #3099 and #3481

@Rowlando13 Rowlando13 added this to the 8.5.0 milestone Jul 16, 2026
@Rowlando13 Rowlando13 linked an issue Jul 16, 2026 that may be closed by this pull request
@Rowlando13 Rowlando13 changed the title Mark get_binary_stream and get_text_stream as deprecated. Mark clearly functions private status. Deprecated Python 2 utilities. Jul 16, 2026
@Rowlando13 Rowlando13 linked an issue Jul 16, 2026 that may be closed by this pull request
@Rowlando13
Rowlando13 requested a review from kdeldycke July 16, 2026 22:16
@Rowlando13

Copy link
Copy Markdown
Member Author

@kdeldycke Please review with a careful eye. I have not done depredations for a package before.

@kdeldycke kdeldycke left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @Rowlando13 ! You beat me to it as I was putting this deprecation work in my todo list. Works great and the only feedbacks I have is mostly nipicking documentation details.

Comment thread src/click/__init__.py
Comment thread src/click/utils.py Outdated
Comment thread docs/handling-files.md Outdated
Comment thread src/click/utils.py Outdated
Comment thread src/click/utils.py Outdated
Comment thread src/click/utils.py Outdated
Comment thread src/click/utils.py Outdated
Comment thread src/click/utils.py Outdated
@kdeldycke
kdeldycke requested a review from davidism July 17, 2026 13:13
@Rowlando13

Copy link
Copy Markdown
Member Author

@kdeldycke Fixes made.

@Rowlando13
Rowlando13 merged commit 333c28d into pallets:main Jul 17, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Python 2 utilities and little used utilities Make unimported utilities explicitely private

2 participants