--show-diff-on-failure does not respect --color

[chadrik]

I'm running pre-commit on gitlab, and I noticed that the diffs produced when --show-diff-on-failure is enabled do not respect --color=always.

It looks like a pretty easy fix: we just need to pass the --color setting to git diff. It supports the same "auto", "always", "never" settings as pre-commit.

git diff --color documentation.

code in question: https://github.com/pre-commit/pre-commit/blob/master/pre_commit/commands/run.py#L227

[asottile]

want to submit a PR?

[chadrik]

Sure!

[asottile]

@chadrik ping!

[mandarvaze]

@chadrik If you are busy/not working on this, can I give it a try ?
I came here looking for "good-first-issue"

[asottile]

@mandarvaze I say go for it 👍 -- let me know if you want some more directed pointers about where this code is and what to pass through :)

[chadrik]

Hi, sorry I’ve been busy. Please feel free to go for it!

…

On Thu, May 30, 2019 at 6:36 AM Anthony Sottile ***@***.***> wrote: @mandarvaze <https://github.com/mandarvaze> I say go for it 👍 -- let me know if you want some more directed pointers about where this code is and what to pass through :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1007?email_source=notifications&email_token=AAAPOE3WP4KF7FRAT5FDFCDPX7J4HA5CNFSM4HIGG5FKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWSKZSI#issuecomment-497331401>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAPOE42VKQADBBVSM3HZ5DPX7J4HANCNFSM4HIGG5FA> .

[asottile]

this has been released as part of v1.17.0 -- thanks again for the issue!

[chadrik]

Thanks for the solution!

…

On Thu, Jun 6, 2019 at 8:32 AM Anthony Sottile ***@***.***> wrote: this has been released as part of v1.17.0 <https://github.com/pre-commit/pre-commit/releases/tag/v1.17.0> -- thanks again for the issue! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1007?email_source=notifications&email_token=AAAPOE4QKRKWHRP5A27QPLLPZEUZLA5CNFSM4HIGG5FKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXDHRXA#issuecomment-499546332>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAPOE6YQSOBWX3CBE4NTW3PZEUZLANCNFSM4HIGG5FA> .