Skip to content

bpo-40147: Move the check for duplicate keywords to the compiler#19289

Merged
pablogsal merged 2 commits into
python:masterfrom
pablogsal:bpo-40147
Apr 3, 2020
Merged

bpo-40147: Move the check for duplicate keywords to the compiler#19289
pablogsal merged 2 commits into
python:masterfrom
pablogsal:bpo-40147

Conversation

@pablogsal

@pablogsal pablogsal commented Apr 2, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@pablogsal
pablogsal requested a review from gvanrossum April 2, 2020 00:24
@pablogsal

pablogsal commented Apr 2, 2020

Copy link
Copy Markdown
Member Author

As a bonus now we print the actual keyword that is repeated.

Before:

❯ python lel.py                       
  File "lel.py", line 1
    f(1, x=2, *(3, 4), x=5)
                       ^
SyntaxError: keyword argument repeated

After:

❯ ./python lel.py  
  File "/home/pablogsal/github/python/master/lel.py", line 1
    f(1, x=2, *(3, 4), x=5)
                       ^
SyntaxError: keyword argument repeated: x

@pablogsal

pablogsal commented Apr 2, 2020

Copy link
Copy Markdown
Member Author

CC: @lysnikolaou

@pablogsal pablogsal self-assigned this Apr 2, 2020
lysnikolaou
lysnikolaou reviewed Apr 2, 2020
View reviewed changes
Comment thread Python/compile.c Outdated
gvanrossum
gvanrossum approved these changes Apr 3, 2020
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! That was simpler than I expected.

@pablogsal
pablogsal merged commit 254ec78 into python:master Apr 3, 2020
@pablogsal
pablogsal deleted the bpo-40147 branch April 3, 2020 19:42
@lysnikolaou lysnikolaou mentioned this pull request Apr 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lysnikolaou lysnikolaou lysnikolaou left review comments
@gvanrossum gvanrossum gvanrossum approved these changes

Assignees

@pablogsal pablogsal

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pablogsal @gvanrossum @lysnikolaou @the-knights-who-say-ni @bedevere-bot