Skip to content

bpo-40903: Handle multiple '=' in invalid assignment rules in the PEG parser#20697

Merged
miss-islington merged 7 commits into
python:masterfrom
pablogsal:bpo-40903
Jun 8, 2020
Merged

bpo-40903: Handle multiple '=' in invalid assignment rules in the PEG parser#20697
miss-islington merged 7 commits into
python:masterfrom
pablogsal:bpo-40903

Conversation

@pablogsal

@pablogsal pablogsal commented Jun 7, 2020

Copy link
Copy Markdown
Member

@pablogsal
pablogsal requested review from gvanrossum and lysnikolaou and removed request for gvanrossum June 7, 2020 22:54
Comment thread Grammar/python.gram Outdated
@stestagg

stestagg commented Jun 8, 2020

Copy link
Copy Markdown
Contributor

Hi

I think I've found another one:

a=yield=1

seems to segfault even with these patches

Steve

@pablogsal

pablogsal commented Jun 8, 2020

Copy link
Copy Markdown
Member Author

I think I've found another one:

Thanks for the catch! Handled in f259e98

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miss-islington
miss-islington merged commit 9f49590 into python:master Jun 8, 2020
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot

Copy link
Copy Markdown

GH-20704 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Jun 8, 2020
… parser (GH-20697)

Automerge-Triggered-By: @pablogsal
(cherry picked from commit 9f49590)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@pablogsal
pablogsal deleted the bpo-40903 branch May 19, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants