Skip to content

bpo-43721: Fix docstrings for property.getter/setter/deleter#31046

Merged
iritkatriel merged 2 commits into
python:mainfrom
iritkatriel:bpo-43721
Mar 14, 2022
Merged

bpo-43721: Fix docstrings for property.getter/setter/deleter#31046
iritkatriel merged 2 commits into
python:mainfrom
iritkatriel:bpo-43721

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Feb 1, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@iritkatriel
iritkatriel requested a review from pitrou February 1, 2022 10:09
pitrou
pitrou reviewed Feb 1, 2022
View reviewed changes

@pitrou pitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I've never been very acquainted with the property implementation. @rhettinger Do you want to take a look?

@pitrou
pitrou requested a review from rhettinger February 1, 2022 10:44
@iritkatriel
iritkatriel requested a review from benjaminp February 9, 2022 16:07
@iritkatriel
iritkatriel merged commit e3d348a into python:main Mar 14, 2022
@miss-islington

miss-islington commented Mar 14, 2022

Copy link
Copy Markdown
Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Mar 14, 2022

Copy link
Copy Markdown
Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 14, 2022
@iritkatriel @miss-islington
bpo-43721: Fix docstrings for property.getter/setter/deleter (pythonG…
c3e7ce0 
…H-31046)

(cherry picked from commit e3d348a)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented Mar 14, 2022

Copy link
Copy Markdown

GH-31886 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Mar 14, 2022
@bedevere-bot

bedevere-bot commented Mar 14, 2022

Copy link
Copy Markdown

GH-31887 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 14, 2022
@iritkatriel @miss-islington
bpo-43721: Fix docstrings for property.getter/setter/deleter (pythonG…
1d703e1 
…H-31046)

(cherry picked from commit e3d348a)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Mar 14, 2022
@miss-islington @iritkatriel
bpo-43721: Fix docstrings for property.getter/setter/deleter (GH-31046)
cebdc32 
(cherry picked from commit e3d348a)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Mar 14, 2022
@miss-islington @iritkatriel
bpo-43721: Fix docstrings for property.getter/setter/deleter (GH-31046)
f1a5e1b 
(cherry picked from commit e3d348a)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@hugovk hugovk mentioned this pull request Mar 15, 2022
Merged
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @iritkatriel @hello-adam
bpo-43721: Fix docstrings for property.getter/setter/deleter (pythonG…
34887ce 
…H-31046)

(cherry picked from commit e3d348a)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@iritkatriel
iritkatriel deleted the bpo-43721 branch October 18, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou left review comments
@rhettinger rhettinger Awaiting requested review from rhettinger
@benjaminp benjaminp Awaiting requested review from benjaminp

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@iritkatriel @miss-islington @bedevere-bot @pitrou @the-knights-who-say-ni