bpo-32790: Added info about alt format using # for 'g' in chart#6624
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. When your account is ready, please add a comment in this pull request Thanks again to your contribution and we look forward to looking at it! |
JulienPalard
left a comment
JulienPalard
left a comment
There was a problem hiding this comment.
I think the paragraph is too long, especially "The alternate form is defined differently for different types." which is not specific to g, so it can be removed.
Beware, also, that the decimal point is also kept using the alternate form, not only trailing zeros. So I propose to extend the sentence:
In both cases insignificant trailing zeros are removed from the significand, and the decimal point is also removed if there are no remaining digits following it.
by simply adding "unless the # flag is used.".
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be put in the comfy chair! |
|
Thanks @bchhabra2490 for the PR, and @matrixise for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
…onGH-6624) (cherry picked from commit d44542f) Co-authored-by: bchhabra2490 <bchhabra2490@gmail.com>
|
GH-16121 is a backport of this pull request to the 3.8 branch. |
…onGH-6624) (cherry picked from commit d44542f) Co-authored-by: bchhabra2490 <bchhabra2490@gmail.com>
|
GH-16122 is a backport of this pull request to the 3.7 branch. |
) (cherry picked from commit d44542f) Co-authored-by: bchhabra2490 <bchhabra2490@gmail.com>
) (cherry picked from commit d44542f) Co-authored-by: bchhabra2490 <bchhabra2490@gmail.com>
7 participants
Added additional information in the chart for format parameter 'g'. @CuriousLearner
https://bugs.python.org/issue32790