Support "square bracket around @param name inside JSDoc for optional params" notation

[p-bakker]

Implements #445

[marijnh]

You have \s* inside of the parentheses for name[1], which makes comparing the group directly to [ will fail (unintentionally, it appears) when there's whitespace after the opening bracket.

[p-bakker]

I'm trying to figure out in which scenario the regex would fail, but can't figure it out. All scenario's I test seem to work:

[name] 
 [name] 
[ name] 
 [ name]    
[name ] 
 [name  ] 
[ name ] 
 [ name  ]  

[marijnh]

This produces false:

/^\s*(\[?\s*)([^\]\s]+)\s*(\]?).*/.exec("[ name]")[1] == "["

So my impression is that your code doesn't actually add the question mark when there is whitespace after the [.

[p-bakker]

Fixed the anomaly

[marijnh]

Thanks. Merged as f127557

[Sevin777]

This is not working properly when using optional parameter and default value (the parameter is not displayed as optional)

http://usejsdoc.org/tags-param.html

Example of Problem

http://ternjs.net/doc/demo.html

Proper Behavior

My Tern plugin modifies the contents of tooltips by re-parsing the jsdocs. I just upgraded to the latest Tern version which is why I found this issue as I had to update my re-parsing and matching with terns arg hints data due to the ? now being appended to optional params. I'm NOT suggesting that tern modifies it's response to look like my arg hints, I'm just showing that tern should recognize that the second parameter is optional.

[marijnh]

Attached patch should fix the parsing of [foo=10] style parameter declarations.