fix: preserve tool approval signatures when approvals are responded#16589
Merged
Conversation
# Conflicts: # packages/ai/src/ui/chat.test.ts # packages/ai/src/ui/chat.ts
dnukumamras
approved these changes
Jul 9, 2026
Contributor
|
🚀 Published in:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Tool approvals signed via experimental_toolApprovalSecret lost their signature when moving from approval-requested to approval-responded, causing resumed requests to fail signature validation with a missing signature error.
Summary
Updated manual chat approval responses and streamed tool approval responses to carry forward an existing approval.signature while preserving existing approval metadata.
Testing
Added regression coverage for manual addToolApprovalResponse and streamed tool-approval-response transitions to assert approval signatures remain on the responded approval state.
Related Issues
Fixes #16543