python3 de-linting#14973
Merged
Merged
Conversation
xrange give a very very slight memory optimization but is incompatible with python3
annevk
approved these changes
Jan 21, 2019
annevk
left a comment
annevk
left a comment
Member
There was a problem hiding this comment.
I'm happy with this provided it works in Python 2. Performance shouldn't be a big deal given the small number.
This was referenced Jan 21, 2019
thefourtheye
approved these changes
Jan 21, 2019
|
The taskcluster hasn't responded yet. Is this normal? |
Member
|
No, I asked @jgraham on IRC to look into it. |
|
Thanks a lot @annevk :-) |
Member
|
That's… weird. Presumably some request failing to get through in some direction. :( Let's close/reopen to re-trigger it, even though really this should be safe enough just to merge. |
I totally agree. Thanks @annevk and @gsnedders 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xrange give a very very slight memory (premature?) optimization in python2, but is incompatible with python3
Refs: https://docs.python.org/3/whatsnew/3.0.html#views-and-iterators-instead-of-lists