Styles and classes - #413

dbritto-dev · 2020-10-08T17:47:47Z

No description provided.

dbritto-dev · 2020-10-08T17:49:10Z

@vplentinax el archivo de 2-ui/1-document/08-styles-and-classes/solution.md esta vacío

vplentinax · 2020-10-08T17:55:36Z

@danilobrinu Comprueba si en la repo de inglés está vacío también. Si tiene contenido, tradúcelo tomando el contenido de allí.

dbritto-dev · 2020-10-08T18:04:36Z

@vplentinax en el repo original también lo está.

repo original: https://github.com/javascript-tutorial/en.javascript.info/blob/master/2-ui/1-document/08-styles-and-classes/2-create-notification/solution.md

vplentinax · 2020-10-08T18:11:29Z

Pues entonces no hay problema. No hay contenido. No se traduce nada.

joaquinelio · 2020-10-09T04:22:20Z

@vplentinax @danilobrinu
pienen como programadores!!

"server" precisa estructura rigida,
cuando encuentra article lo agrega, numera y titula sin que nadie tenga que ponerlo en una lista,
cuando ve task + solution los pone al final del article sin que nadie necesite ponerlo explicitamente
probablemente solution vacio habilita el boton, quizas con solamente el link al sandbox

nota:
El boton y link a sandbox de "solution" está bien traducido, pero
¿no les parece qie suena un poco raro? copio:
"Solución
Abrir la solución con pruebas en un entorno controlado."

dbritto-dev · 2020-10-09T05:26:08Z

@vplentinax @danilobrinu
pienen como programadores!!

"server" precisa estructura rigida,
cuando encuentra article lo agrega, numera y titula sin que nadie tenga que ponerlo en una lista,
cuando ve task + solution los pone al final del article sin que nadie necesite ponerlo explicitamente
probablemente solution vacio habilita el boton, quizas con solamente el link al sandbox

nota:
El boton y link a sandbox de "solution" está bien traducido, pero
¿no les parece qie suena un poco raro? copio:
"Solución
Abrir la solución con pruebas en un entorno controlado."

La verdad no te entendi nada jaja y no creo que tenga que ver con pensar como programador o no.

joaquinelio · 2020-10-09T06:32:29Z

era solo una curiosidad, de por qué agregar solution vacio

javascript-translate-bot · 2020-10-17T21:54:16Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

dbritto-dev · 2020-10-17T22:20:39Z

/done

joaquinelio

Se me escapó una.
Dos.
Creo que es todo.

javascript-translate-bot · 2020-10-18T03:26:15Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

dbritto-dev · 2020-10-18T13:31:26Z

/done

vplentinax

OK

javascript-translate-bot · 2020-10-20T01:13:52Z

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

joaquinelio · 2020-10-20T01:30:35Z

@vplentinax @danilobrinu

Me canse de hacer pr y me permiti hacer un commit directo, pero aviso.

task estaba traducida, faltaba una linea
"the options are" a "Las opciones son"
La solucion esta vacia porque solo funciona en nueva pagina o plnkr
y funciona nicely

javascript-translate-bot added the review needed label Oct 8, 2020

javascript-translate-bot requested a review from a team October 8, 2020 17:47

javascript-translate-bot mentioned this pull request Oct 8, 2020

Spanish Translation Progress #17

Open

vplentinax reviewed Oct 9, 2020

View reviewed changes

Comment thread 2-ui/1-document/08-styles-and-classes/article.md Outdated

WIP

5505fec

dbritto-dev force-pushed the styles-classes branch from 66f9495 to 5505fec Compare October 12, 2020 17:16

dbritto-dev added 7 commits October 12, 2020 13:14

WIP

bd4b67a

WIP

557466d

WIP

dbb4233

WIP

cd18376

WIP

07af51a

WIP

833c318

Minor changes

4aaafbf

dbritto-dev marked this pull request as ready for review October 17, 2020 18:34

joaquinelio requested changes Oct 17, 2020

View reviewed changes

javascript-translate-bot removed the review needed label Oct 17, 2020

javascript-translate-bot added the changes requested label Oct 17, 2020

dbritto-dev and others added 5 commits October 17, 2020 17:18

Update 2-ui/1-document/08-styles-and-classes/article.md

1910164

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/1-document/08-styles-and-classes/article.md

a6bce5b

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/1-document/08-styles-and-classes/article.md

5bae251

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/1-document/08-styles-and-classes/article.md

68bfee0

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/1-document/08-styles-and-classes/article.md

5516205

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

dbritto-dev and others added 5 commits October 17, 2020 17:19

Update 2-ui/1-document/08-styles-and-classes/article.md

da858fa

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/1-document/08-styles-and-classes/article.md

d3f7554

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/1-document/08-styles-and-classes/article.md

4394f5b

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/1-document/08-styles-and-classes/article.md

1409fae

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/1-document/08-styles-and-classes/article.md

b335cf5

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

javascript-translate-bot added review needed and removed changes requested labels Oct 17, 2020

javascript-translate-bot requested a review from a team October 17, 2020 22:20

joaquinelio requested changes Oct 18, 2020

View reviewed changes

Comment thread 2-ui/1-document/08-styles-and-classes/article.md Outdated

Comment thread 2-ui/1-document/08-styles-and-classes/article.md Outdated

javascript-translate-bot removed the review needed label Oct 18, 2020

javascript-translate-bot added the changes requested label Oct 18, 2020

dbritto-dev and others added 2 commits October 18, 2020 08:31

Update 2-ui/1-document/08-styles-and-classes/article.md

0022411

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/1-document/08-styles-and-classes/article.md

e2cc988

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

javascript-translate-bot added review needed and removed changes requested labels Oct 18, 2020

javascript-translate-bot requested a review from a team October 18, 2020 13:31

joaquinelio approved these changes Oct 19, 2020

View reviewed changes

javascript-translate-bot added needs +1 and removed review needed labels Oct 19, 2020

vplentinax approved these changes Oct 19, 2020

View reviewed changes

vplentinax added ready to merge and removed needs +1 labels Oct 19, 2020

joaquinelio merged commit 9eb6aa8 into javascript-tutorial:master Oct 20, 2020

Uh oh!

Conversation

dbritto-dev commented Oct 8, 2020

Uh oh!

dbritto-dev commented Oct 8, 2020

Uh oh!

vplentinax commented Oct 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dbritto-dev commented Oct 8, 2020

Uh oh!

vplentinax commented Oct 8, 2020

Uh oh!

joaquinelio commented Oct 9, 2020

Uh oh!

dbritto-dev commented Oct 9, 2020

Uh oh!

joaquinelio commented Oct 9, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Oct 17, 2020

Uh oh!

dbritto-dev commented Oct 17, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Oct 18, 2020

Uh oh!

dbritto-dev commented Oct 18, 2020

Uh oh!

vplentinax left a comment

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Oct 20, 2020

Uh oh!

joaquinelio commented Oct 20, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vplentinax commented Oct 8, 2020 •

edited

Loading