Skip to content

Fetch: Cross-Origin Requests - #427

Merged
joaquinelio merged 23 commits into
javascript-tutorial:masterfrom
MaskeZen:cross-origin-requests
Oct 30, 2020
Merged

joaquinelio merged 23 commits into
javascript-tutorial:masterfrom
MaskeZen:cross-origin-requests

Conversation

@MaskeZen

Copy link
Copy Markdown
Contributor

Se actualiza con la versiΓ³n en inglΓ©s y se traduce el artΓ­culo.
Tengo algunas dudas con el tΓ©rmino solicitud de "pre-vuelo" y el haber traducido "cross-origin", aunque en el caso de cross-origin, utilicΓ© en un par de casos entre parΓ©ntesis el termino en inglΓ©s junto a la traducciΓ³n para que el lector hispano tenga contacto con el termino original.

Espero no de muchos dolores de cabeza la revisiΓ³n, saludos! πŸ§‰

@joaquinelio

Copy link
Copy Markdown
Member

ooops conflictos... mejor lo veo despues

dont worry, es que la sync estΓ‘ bastante al dia seguro son faciles,
y como decis que te basaste en ingles resuelvo aceptando lo tuyo, deben ser los mismos cambios.

@joaquinelio
joaquinelio self-requested a review October 19, 2020 05:38
@joaquinelio

Copy link
Copy Markdown
Member

Todavia no lo revise, pero veo que tiene 1 ejerccicio tambien prar traducir
task solution
por las dudas: los svg no se tocan, tienen tratamiento especial.

@MaskeZen

Copy link
Copy Markdown
Contributor Author

Todavia no lo revise, pero veo que tiene 1 ejerccicio tambien prar traducir
task solution
por las dudas: los svg no se tocan, tienen tratamiento especial.

Impecable, ahΓ­ agreguΓ© esos archivos que se me habΓ­an pasado.

Comment thread 5-network/05-fetch-crossorigin/1-do-we-need-origin/solution.md Outdated
Comment thread 5-network/05-fetch-crossorigin/article.md Outdated
Comment thread 5-network/05-fetch-crossorigin/article.md Outdated
Comment thread 5-network/05-fetch-crossorigin/article.md Outdated
Comment thread 5-network/05-fetch-crossorigin/article.md Outdated
Comment thread 5-network/05-fetch-crossorigin/article.md Outdated
Comment thread 5-network/05-fetch-crossorigin/article.md Outdated
Comment thread 5-network/05-fetch-crossorigin/article.md Outdated
Comment thread 5-network/05-fetch-crossorigin/article.md Outdated
Comment thread 5-network/05-fetch-crossorigin/article.md Outdated
@javascript-translate-bot

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review πŸ‘»

@joaquinelio joaquinelio changed the title Cross origin requests Fetch: Cross-Origin Requests Oct 22, 2020
@joaquinelio

Copy link
Copy Markdown
Member

corregido nombre pr pa'q bot lo entienda
corregido a issue17 pr427

MaskeZen and others added 12 commits October 22, 2020 22:57
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
MaskeZen and others added 3 commits October 22, 2020 23:18
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@MaskeZen

Copy link
Copy Markdown
Contributor Author

/done

@vplentinax vplentinax left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buena traducciΓ³n, solo algunas sugerencias.

Comment thread 5-network/05-fetch-crossorigin/1-do-we-need-origin/task.md Outdated
Comment thread 5-network/05-fetch-crossorigin/article.md Outdated
Comment thread 5-network/05-fetch-crossorigin/article.md Outdated
Comment thread 5-network/05-fetch-crossorigin/article.md Outdated
Comment thread 5-network/05-fetch-crossorigin/article.md
Comment thread 5-network/05-fetch-crossorigin/article.md Outdated
Comment thread 5-network/05-fetch-crossorigin/article.md Outdated
Comment thread 5-network/05-fetch-crossorigin/article.md Outdated
Comment thread 5-network/05-fetch-crossorigin/article.md Outdated
Comment thread 5-network/05-fetch-crossorigin/article.md Outdated
@javascript-translate-bot

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review πŸ‘»

@joaquinelio

Copy link
Copy Markdown
Member

SΓ­, es terrible.
-prevuelo lo escribiria sin guion, pero no afecta. Y no sΓ© quΓ© tan prΓ‘ctica es la metΓ‘fora si se entiende igual.
-no me gustan las redundancias, solicitud - solicitud
-aun hay algun problema de concordacias, ojo la sug de voz pasiva reformulada creo que tamb estΓ‘ mal.
-y por supuesto, las comas medievales de mΓ‘s. Las comas no son para marcar pausas. Batalla que asumo perdida pero siempre lo apunto.

Pero mientras no afecte el concepto, apruebo lo que venga.
Ja ja !!!
estΓ‘ bueno.

Lo leo desp de que revises la revision de Valentina...

MaskeZen and others added 2 commits October 26, 2020 21:28
Se agregan sugerencias de vplentinax.

Co-authored-by: Valentina VP <34555644+vplentinax@users.noreply.github.com>
Se remueve el es. de las URLs
@MaskeZen

Copy link
Copy Markdown
Contributor Author

CortΓ© por lo sano y removΓ­ los es. de las URLs.

/done

Se remueve el es. de las URLs

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘
Yo creo que es hermoso.

@joaquinelio

Copy link
Copy Markdown
Member

Por las dudas, entendiste que "es terrible" era un chiste, ΒΏno?
Me han dicho que chistes, sarcasmos e ironias debo hacerlos explicitos con protocolos tags o emoji
quΓ© gracia asi.

Como sea, aprobemos este bodrio asΓ­ nos lo sacamos de encima.

@MaskeZen

Copy link
Copy Markdown
Contributor Author

πŸ‘πŸ½ SΓ­, lo interpretΓ© en una buena.
Ya casi... jejeje

@vplentinax vplentinax left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oki

@joaquinelio
joaquinelio merged commit efd631b into javascript-tutorial:master Oct 30, 2020
@javascript-translate-bot

Copy link
Copy Markdown

Thank you πŸ’– I updated the Progress Issue #17 πŸŽ‰ πŸŽ‰ πŸŽ‰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants