Skip to content

Shadow DOM slots, composition - #561

Merged
joaquinelio merged 16 commits into
javascript-tutorial:masterfrom
MaxSierra16:master
Oct 18, 2021
Merged

Shadow DOM slots, composition#561
joaquinelio merged 16 commits into
javascript-tutorial:masterfrom
MaxSierra16:master

Conversation

@MaxSierra16

@MaxSierra16 MaxSierra16 commented Oct 13, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a team October 13, 2021 02:15
@joaquinelio
joaquinelio self-requested a review October 13, 2021 06:21
joaquinelio
joaquinelio requested changes Oct 13, 2021
View reviewed changes

@joaquinelio joaquinelio left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hola

muy bueno

acepta las sug que quieras
cualquier cosa. se puede discutir

ah, cambie el nombre pra q Don Bot se entere.
pfffff no se enteró, edito el progress a mano #17

notas
podes editar online el PR,
tamb podes modif tu branch local y cuando lo subis con push se modifica el pr automaticamente

modificaste tu master, no es problema para mi
pero la idea es tener tu master SIEMPRE LIMPIO, sincronizado con master upstream
haces branch
ej max : branch1
lo modificas, lo subis, y con suerte te lo aceptan
1
si upstram:master se actualiza sin tu pr, el tuyo no quedaria desencajado
2
podes hacer otra modifcacion independiente en branch2 sin trrastear la primera

Comment thread 8-web-components/5-slots-composition/article.md Outdated
Comment thread 8-web-components/5-slots-composition/article.md
Comment thread 8-web-components/5-slots-composition/article.md Outdated
Comment thread 8-web-components/5-slots-composition/article.md Outdated
Comment thread 8-web-components/5-slots-composition/article.md Outdated
Comment thread 8-web-components/5-slots-composition/article.md Outdated
Comment thread 8-web-components/5-slots-composition/article.md Outdated
Comment thread 8-web-components/5-slots-composition/article.md Outdated
Comment thread 8-web-components/5-slots-composition/article.md Outdated
Comment thread 8-web-components/5-slots-composition/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Oct 13, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@joaquinelio joaquinelio changed the title Traduccion Shadow DOM slots, composición Shadow DOM slots, composition Oct 13, 2021
@joaquinelio joaquinelio mentioned this pull request Oct 13, 2021
Open
@MaxSierra16 @joaquinelio
Update 8-web-components/5-slots-composition/article.md
d86e408 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@MaxSierra16

MaxSierra16 commented Oct 14, 2021

Copy link
Copy Markdown
Contributor Author

@joaquinelio Gracias por tus observaciones. De verdad fueron muy acertadas. Hoy mismo estare pushiando los cambios 🚀

MaxSierra16 and others added 10 commits October 15, 2021 10:54
@MaxSierra16 @joaquinelio
Update 8-web-components/5-slots-composition/article.md
aae4aeb 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@MaxSierra16 @joaquinelio
Update 8-web-components/5-slots-composition/article.md
82bf64c 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@MaxSierra16 @joaquinelio
Update 8-web-components/5-slots-composition/article.md
f7b1b3e 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@MaxSierra16 @joaquinelio
Update 8-web-components/5-slots-composition/article.md
81643df 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@MaxSierra16 @joaquinelio
Update 8-web-components/5-slots-composition/article.md
fc5090d 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@MaxSierra16 @joaquinelio
Update 8-web-components/5-slots-composition/article.md
19ee397 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@MaxSierra16 @joaquinelio
Update 8-web-components/5-slots-composition/article.md
b6d1a6d 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@MaxSierra16 @joaquinelio
Update 8-web-components/5-slots-composition/article.md
618d69c 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@MaxSierra16
Cambios sugeridos localmente.
19ff453
@MaxSierra16 @joaquinelio
Update 8-web-components/5-slots-composition/article.md
a2d17a2 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@MaxSierra16

MaxSierra16 commented Oct 15, 2021

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a team October 15, 2021 15:29
@MaxSierra16
MaxSierra16 requested review from joaquinelio and removed request for a team October 15, 2021 15:30
joaquinelio
joaquinelio reviewed Oct 15, 2021
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lo lei y me parecio muy bien,

pero 2 sugerencias que no incorporaste y me parece que deben resolverse

447 .... "los métodos: " o "estos métodos : "
...
...

451, pienso tmbién cómo es más facil leer
evito el potencial y el reflexivo "nos gustaría"

"Si queremos saber, podemos..."
o
"Si quisiéramos saber, podríamos "

Si no contestás lo agrego como está,
preferible online aunque tuviera errores

@MaxSierra16

MaxSierra16 commented Oct 18, 2021

Copy link
Copy Markdown
Contributor Author

Si queremos saber, podemos

Cool 🚀

@MaxSierra16

MaxSierra16 commented Oct 18, 2021

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a team October 18, 2021 13:00
@MaxSierra16
MaxSierra16 requested review from joaquinelio and removed request for a team October 18, 2021 13:00
joaquinelio
joaquinelio approved these changes Oct 18, 2021
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no puedo verlo bien ahora
estaba bueno antes ,estara mejor ahora, cheqealo online,
problemas, nuevo pr y cuandopueda vuelvo
salud

@joaquinelio
joaquinelio merged commit 5652645 into javascript-tutorial:master Oct 18, 2021
@javascript-translate-bot

javascript-translate-bot commented Oct 18, 2021

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

@joaquinelio

joaquinelio commented Oct 18, 2021

Copy link
Copy Markdown
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MaxSierra16 @javascript-translate-bot @joaquinelio