Skip to content

Allow display:inline-block on spans style - #180498

Merged
1 commit merged into
microsoft:mainfrom
yoavbls:allow-display-prop-in-spans-style
Sep 14, 2026
Merged

1 commit merged into
microsoft:mainfrom
yoavbls:allow-display-prop-in-spans-style

Conversation

@yoavbls

Copy link
Copy Markdown
Contributor

Solves #180496

@gjsjohnmurray

Copy link
Copy Markdown
Contributor

Pinging Matt Bierner (@mjbvz) who might have an opinion about this change.

@yoavbls

Yoav Balasiano (yoavbls) commented Mar 1, 2024 •

Copy link
Copy Markdown
Contributor Author

Matt Bierner (@mjbvz) Hey Matt,
I'm sorry I'm pinging you about it, but almost a year has passed, and I would be pleased if you could take a look at it and provide some clarification on the desired solution 🙏🏼

@aminya

Amin Ya (aminya) commented May 31, 2024 •

Copy link
Copy Markdown
Contributor

This oneliner fixes the only missing feature of ts-pretty-errors. Could someone take a look? Looks like one year should have been enough time for reviewing this simple fix.

@xenostar

Copy link
Copy Markdown

Hello Matt Bierner (@mjbvz) and John Murray (@gjsjohnmurray). It has been nearly 1.5 years since this PR was opened. Are there any further reservations about merging this in? This enables a fix for #180496, which will enable a massive developer experience improvement for the Pretty TS Errors plugin.

What are the steps we can take to get this prioritized and possibly merged? This would enable a huge improvement to the DX for nearly one million developer using this plugin.

@AndreMaz

Copy link
Copy Markdown

Any chance of merging this PR Matt Bierner (@mjbvz) ?

@alanmoyano

Copy link
Copy Markdown

Hello! Matt Bierner (@mjbvz) could you please check this out? This would be awesome for empowering extension developers.

@mbtools

Copy link
Copy Markdown

There's now a little conflit, yoavbls. Let's resolve it and give it another bump. TY! :-)

@yoavbls
Yoav Balasiano (yoavbls) force-pushed the allow-display-prop-in-spans-style branch from 91e8c53 to 6a26c24 Compare March 29, 2025 22:18
@yoavbls Yoav Balasiano (yoavbls) changed the title Allow display prop on spans style Allow display:inline-block on spans style Mar 29, 2025
@yoavbls

Copy link
Copy Markdown
Contributor Author

Marc Bernard (@mbtools) updated, now allowing only inline-block to make it even safer

@mbtools

Copy link
Copy Markdown

LGTM 👍

@alanmoyano

Copy link
Copy Markdown

👀👀

@hexrw

Copy link
Copy Markdown

+1, still relevant

@danielfoxp2

Copy link
Copy Markdown

WoW, not even a reply to say they hated the solution or that the solution conflicts with their personal preferences and will not be merged?

This can easily impact millions of developers (me included) to a better experience and not a single word for years?

Shame.

@ouardito

Copy link
Copy Markdown

Since Microsoft / The Assignee / The Reviewer has been silent on this pr for a long time ...

Does anyone know how to, instead, remove the original errors, and only show the Pretty TypeScript Errors ?

@Bodrie

Copy link
Copy Markdown

It takes longer to scroll the thread than to review the change in this PR.... shame

@alexdima Alexandru Dima (alexdima) closed this pull request by merging all changes into microsoft:main in 301db87 Sep 14, 2026
@vs-code-engineering vs-code-engineering Bot added this to the 1.139.0 milestone Sep 14, 2026
pull Bot pushed a commit to Jimimaku/vscode that referenced this pull request Sep 14, 2026
Preserve display:inline-block on sanitized span elements using the current sanitizer architecture, with focused regression coverage.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.