Add upstream Cargo completion spec for terminal suggestions

[Sangeet (Muszic)]

Summary

Adds Cargo terminal completions using the complete upstream withfig/autocomplete Cargo spec instead of a hand-written subset.

Details

• Imports cargo through the existing upstream-spec generation pipeline.
• Covers Cargo's full upstream command and option surface, including dynamic package, target, feature, crate, toolchain, and plugin suggestions.
• Extends the local filepaths adapter to preserve upstream exact-name filters for Cargo.toml and deny.toml.
• Removes an upstream debug console.log during generation.
• Adds regression coverage for the command/build-option surface and exact file-name filters.

Validation

• Terminal Suggest extension-host suite: 384 passing.
• Terminal Suggest TypeScript no-emit check passed.
• Upstream Cargo generation is byte-stable across repeated runs.

Fixes #336216.

[Sangeet (Muszic)]

Alex Ross (@alexr00) Bryan Chen (@bryanchen-d) review and merge the PR please

[Megan Rogge (meganrogge)]

Thank you!

[Copilot]

Pull request overview

Adds a new cargo completion spec to the terminal-suggest extension, including dynamic feature-name suggestions sourced from the local project, and wires it into the spec registry and test runner.

Changes:

• Added a new cargo completion spec with common subcommands/options and a cargo read-manifest-based feature generator for --features.
• Registered the new spec in the extension’s availableSpecs.
• Added a dedicated test suite and included it in the main terminal-suggest test runner.

Show a summary per file

File	Description
extensions/terminal-suggest/src/terminalSuggestMain.ts	Registers the new cargo completion spec in availableSpecs.
extensions/terminal-suggest/src/completions/cargo.ts	Implements cargo subcommands/options and a dynamic generator for --features.
extensions/terminal-suggest/src/test/completions/cargo.test.ts	Adds basic completion coverage for the cargo spec.
extensions/terminal-suggest/src/test/terminalSuggestMain.test.ts	Wires the new cargo test suite into the aggregated runner.

Copilot's findings

• Files reviewed: 4/4 changed files
• Comments generated: 2

[Dmitriy Vasyura (dmitrivMS)]

Sangeet (@Muszic) Could you please address Copilot's comments and look at the failing CI?

[Sangeet (Muszic)]

Dmitriy Vasyura (@dmitrivMS) Could you please review the PR , I have addressed all the comments

[Copilot]

Copilot's findings

• Files reviewed: 4/4 changed files
• Comments generated: 0 new

[Dmitriy Vasyura (dmitrivMS)]

Sangeet (@Muszic) Thanks for working on this! Would you be so kind as to review the AI feedback below? My understanding is if not all, but most points make sense:

---

1. --features is on the wrong level

const cargoSpec: Fig.Spec = {
    name: 'cargo',
    subcommands: [ /* build, run, test, ... */ ],
    options: [
        { name: ['-F', '--features'], args: { generators: cargoFeaturesGenerator } },
        ...
    ]
};

These options apply to top-level cargo only, not to subcommands. Nobody types cargo --features foo — it's cargo build --features foo, cargo test --features foo, cargo run --features foo, etc. As written, the dynamic feature generator never actually fires in real usage. Could persistentOptions work instead, or pushing --features onto each of build / run / test / check / bench / clippy / install / doc?

2. Coverage is thin for a daily Rust user

The spec lists ~14 subcommands and 5 options. Cargo has ~30 subcommands and most of the value of completions is the per-subcommand option set. Missing in particular:

• Subcommands: bench, install, uninstall, search, tree, metadata, package, yank, owner, fix, rustc, rustdoc, generate-lockfile, vendor, login, logout, locate-project, pkgid.
• Options users hit constantly: --release, --profile, --target, --target-dir, --manifest-path, --workspace, -p/--package, --bin, --lib, --example, --test, --bench, -j/--jobs, --offline, --locked, --frozen, -v/-vv/-q.

Have you looked at whether we can adopt the upstream withfig/autocomplete cargo spec into src/completions/upstream/ instead? That's the pattern we use for other large specs (see src/completions/upstream/git.ts / docker.ts / dotnet.ts) — it's much more complete and we get upstream fixes for free. Hand-rolling cargo here means we own the maintenance forever and we're already shipping with most of the surface missing.

3. Cache TTL of 5s is too aggressive

cache: {
    strategy: 'stale-while-revalidate',
    ttl: 5_000,
    cacheByDirectory: true
},

cargo read-manifest is not cheap on cold cache (hundreds of ms in larger workspaces), and Cargo.toml doesn't change every 5s. Could we bump this to a minute or two? Even better: invalidate on Cargo.toml file change rather than time-based.

4. console.error in the generator

} catch (e) {
    console.error('Failed to parse cargo manifest:', e);
    return [];
}

This shouldn't go through console.error — it'll just be noise. Either drop it or route it through the extension's logger if there is one. The test suite will run this code path repeatedly.

---

[Dmitriy Vasyura (dmitrivMS)]

Megan Rogge (@meganrogge) This is what a full spec looks like. Do we like?

[boedysutris-ctrl]

Pada Sen, 7 Sep 2026 03.38, Dmitriy Vasyura ***@***.***> menulis:

…

***@***.**** approved this pull request. — Reply to this email directly, view it on GitHub <#305309?email_source=notifications&email_token=CM7ETLIRJJSH7S4ZKL6FMND5NXDNXA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMJSGY2TKMZQGMZ2M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM33PORSXEX3DNRUWG2Y#pullrequestreview-5126553033>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/CM7ETLLQY3JXJUKA7YQ42RL5NXDNXAVCNFSNUABEKJSXA33TNF2G64TZHM2DCOBYGE4TAMB3JFZXG5LFHM2DCNBXGQ3TANZZG6QXMAQ> . Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS <https://github.com/notifications/mobile/ios/CM7ETLPOL4RZVZPHJYQ42GD5NXDNXA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMJSGY2TKMZQGMZ2M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSVGM33PORSXEX3JN5ZQ> and Android <https://github.com/notifications/mobile/android/CM7ETLKPN5G2STOVVTOBARD5NXDNXA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMJSGY2TKMZQGMZ2M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSXGM33PORSXEX3BNZSHE33JMQ>. Download it today! You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>