fix: memory leak in issueReporterOverlay

[Simon Siefke (SimonSiefke)]

Details

Saving or discarding an annotation editor left the closed editor and its event subscriptions in the issue reporter's disposable store. Rebuilding screenshot thumbnails also left the previous thumbnails' listeners in that store.

Change

Give each annotation editor a disposable store and remove it on save or discard. Clear thumbnail listeners whenever the thumbnails are rebuilt.

Before

After 37 screenshot annotation reopening cycles, 74 closed annotation editors and 148 DOM listener objects remained, along with their callbacks.

After

No more annotation-editor or thumbnail-listener growth is detected by named-function-count3 over the same 37 cycles.

Test Video

Seven screenshot annotation reopening cycles were recorded and completed successfully.

annotation-test.webm

[Copilot]

🟢 Approval recommended

The focused cleanup changes are correct and covered by relevant regression tests.

Pull request overview

Fixes disposable retention in the issue reporter’s screenshot annotation workflow.

Changes:

• Adds scoped stores for annotation editors and thumbnail listeners.
• Disposes obsolete listeners when thumbnails rebuild.
• Adds regression tests for editor and listener cleanup.

File summaries

File	Description
issueReporterOverlay.ts	Implements scoped lifecycle cleanup.
issueReporterOverlay.test.ts	Tests disposal and listener removal.

Review details

• Files reviewed: 2/2 changed files
• Comments generated: 0
• Review effort level: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Dmitriy Vasyura (dmitrivMS)]

Simon Siefke (@SimonSiefke) Thank you!