[5.x] Fix autoloading when addon has multiple service providers - #11128
Merged
jasonvarga merged 7 commits intoDec 17, 2024
Merged
Conversation
…rs in the same directory
Member
|
I've pushed up some changes so that "root level items" like config, routes, views, blueprints, etc will only get booted by the root provider. I added handling so that if you have multiple providers at the root level, the root level items only get booted once. So, now nested providers can have autoloadable things relative to them like tags, actions, etc. |
edalzell
requested changes
Dec 16, 2024
edalzell
approved these changes
Dec 17, 2024
edalzell
approved these changes
Dec 17, 2024
jasonvarga
approved these changes
Dec 17, 2024
jasonvarga
deleted the
fix/autoloading-when-addon-has-multiple-providers
branch
December 17, 2024 15:34
This was referenced Dec 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This pull request changes the "base path" used when autoloading addon components, to prevent addons with multiple service providers from booting the same stuff multiple times.
Fixes #11082.