[6.x] Respect the listing sort order when exporting form submissions - #15105
Merged
jasonvarga merged 6 commits intoSep 16, 2026
Merged
Conversation
…ns-export-sorting
Explicitly pass the $escape parameter to avoid the PHP 8.4+ deprecation for its implicit default. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
jasonvarga
added a commit
that referenced
this pull request
Sep 16, 2026
Reconciles with #15105, which made the listing sort order apply to both export scopes rather than only the filtered one. Its logic was ported by hand into the extracted ExportSubmissionsModal, which merged cleanly but still carried the pre-#15105 behaviour, and the filtered-scope description now mentions search and filters instead of sort order. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
jasonvarga
added a commit
that referenced
this pull request
Sep 16, 2026
…ests FormExportTest covers permissions on the export route; ExportSubmissionsTest, which arrived with #15105, covers what the export actually produces. The column test belongs in the latter, and no longer needs the role scaffolding it was only using to reach the route. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
jasonvarga
added a commit
that referenced
this pull request
Sep 16, 2026
Exporters can now opt into column selection via supportsColumnSelection(), and receive a subset via setColumns(). The submissions export modal gains a column checkbox list for exporters that support it, and was extracted out of the listing page into its own component. The filtered-scope description no longer mentions sort order, which applies to both scopes since #15105. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Form submission exports ignored the listing's sort order.
The sort was only sent when you picked Filtered Submissions, and that option is disabled unless a search or filter is active. And the default date sort didn't count. So the common case, open a form and hit export, always gave you an arbitrarily ordered file.
Behavior changes
Also
The Filtered Submissions description claimed exports respect the visible columns. They don't, so I dropped that half of the sentence.