This repository was archived by the owner on Oct 2, 2021. It is now read-only.
Persist the client ID when we reset the breakpoints in source mapped … #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
reviewed
Jun 24, 2018
| private _requestSeqToSetBreakpointsArgs: Map<number, ISavedSetBreakpointsArgs>; | ||
| private _allRuntimeScriptPaths: Set<string>; | ||
| private _authoredPathsToMappedBPs: Map<string, DebugProtocol.SourceBreakpoint[]>; | ||
| private _authoredPathsToClientBreakpointIds: Map<string, number[]>; |
Member
There was a problem hiding this comment.
I hate that we have to keep track of the breakpoint IDs in here. But we're already keeping track of the breakpoints anyway. It's not great. Let me think about this a little more.
Contributor
Author
There was a problem hiding this comment.
@roblourens: Did you get a chance to think about this yet?
Contributor
Author
roblourens
approved these changes
Jun 30, 2018
Member
roblourens
left a comment
roblourens
left a comment
There was a problem hiding this comment.
I'm not a fan of this fix but this is the best we can do right now, thanks for the PR
Member
|
@rakatyal please check the unit tests. VSTS isn't building PRs for some reason. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…files
When we clear and reset the breakpoints in the mapped files, we don't persist the client IDs we created for them and sent to PineZorro. This specially causes a problem in Edge which returns a new breakpoint ID when we make the setBreakpointByUrl call again during resetting. Then we end up sending a 'changed' event to PZ for this breakpoint ID which causes an error since we didn't tell the client about it.
This doesn't cause an issue with Chrome currently because Chrome uses a pattern of script_url, line and column number to create the breakpoint ID which remains the same on resetting the breakpoint again.
This change persists the client IDs during the reset process and makes sure it gets mapped to the original one.