Initial React Router support #11498
Initial React Router support #11498
Conversation
🦋 Changeset detectedLatest commit: 6ec04a2 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| "pretty-bytes": "^6.0.0", | ||
| "prompts": "^2.4.2", | ||
| "recast": "0.22.0", | ||
| "recast": "0.23.11", |
There was a problem hiding this comment.
This bump was needed to support the satisfies keyword
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
| await installPackages(["isbot"], { | ||
| dev: true, | ||
| startText: "Installing the isbot package", | ||
| doneText: `${brandColor(`installed`)} ${dim("isbot")}`, | ||
| }); |
There was a problem hiding this comment.
This feels really messy, but does seem to be necessary
| }); | ||
|
|
||
| writeFileSync( | ||
| `app/entry.server.tsx`, |
There was a problem hiding this comment.
We should check if this file already exists before overwriting it
There was a problem hiding this comment.
If it already exists there's not a whole lot we can do, so I went with unconditionally writing on the assumption that someone can revert the change if they need to. Do you think we should just bail if the file exists?
penalosa
force-pushed
the
penalosa/react-router
branch
from
a9ccfe8 to
e2c15ce
Compare
| ` | ||
| ); | ||
|
|
||
| await installPackages(["isbot"], { |
There was a problem hiding this comment.
do we need to have separate installPackages calls? would it make sense to just have one that installs both packages?
There was a problem hiding this comment.
Happy to change it if you'd like. I made it two calls because it makes the output look a little bit nicer
Co-authored-by: Dario Piotrowicz <[email protected]>
Co-authored-by: Dario Piotrowicz <[email protected]>
Co-authored-by: Dario Piotrowicz <[email protected]>
penalosa
force-pushed
the
penalosa/react-router
branch
from
6910673 to
6ec04a2
Compare
3 participants
Fixes https://jira.cfdata.org/browse/DEVX-2324