Update spec test suite submodule#2444
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Feb 10, 2026
Merged
Conversation
Pull in some renamings in the custom descriptors proposal.
cpetig
reviewed
Feb 10, 2026
Contributor
cpetig
left a comment
cpetig
left a comment
There was a problem hiding this comment.
Two bikeshedding comments, overall the structure of the change looks straightforward. But I don't have enough background to make a real judgment.
| to_ref_type: RefType, | ||
| }, | ||
| BrOnCastDescFail { | ||
| BrOnCastDescEqFail { |
Contributor
There was a problem hiding this comment.
🤔 To me BrOnCastDescNe or BrOnCastDescNotEq feels more readable. I see the history, but adding Eq opens an opportunity to step back and rethink the name.
Member
Author
There was a problem hiding this comment.
Oh this is just following upstream spec changes as opposed to making any decisions itself
| from_ref_type, | ||
| to_ref_type, | ||
| } => sink.br_on_cast_desc_fail(relative_depth, from_ref_type, to_ref_type), | ||
| } => sink.br_on_cast_desc_eq_fail(relative_depth, from_ref_type, to_ref_type), |
Contributor
There was a problem hiding this comment.
Similar here, _eq_fail feels less clear than _not_eq
fitzgen
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull in some renamings in the custom descriptors proposal.