fix(update-checker): check that command files are executable by default

[codebymikey]

The Issue

• Follow up from Ensure commands are executable by default ddev-solr#74

Command files should be executable by default

How This PR Solves The Issue

Checks that command files are executable by default.

Manual Testing Instructions

Inside a DDEV addon:

# Create simple non-executable command files
mkdir commands/host/
touch commands/host/{.,_}include-scripts commands/host/non-executable-command

curl -fsSL https://raw.githubusercontent.com/codebymikey/ddev-addon-template/refs/heads/20250327_codebymikey_executable_commands/.github/scripts/update-checker.sh | bash

Automated Testing Overview

N/A

Release/Deployment Notes

N/A

[rfay]

The actual reality... I'm not sure that these have to be executable any more, I think DDEV executes them with bash directly, so that means that DDEV's actual code to make them executable (which is what annoyed you) may be obsolete.

[codebymikey]

Wasn't aware of that. If that's the case, then I'll just close this then.

[rfay]

Well, I'm not 100% sure. But you might fiddle with DDEV a bit to remove the chmod and see if everything still works.

[codebymikey]

I ran into the executable bit issue whilst running the latest DDEV (v1.25.1).

But if the eventual plan is for a future update to stop it from automatically marking files as executable, then I'm all for that, as that seems a bit safer, and ensures the commands are only executable within the DDEV context.

It might break some workflows if they rely on DDEV automatically making the addon commands executable, but I think it's a worthwhile goal.

Do you know the PR/issue where this was discussed/implemented?

The only way I can see it working without the executable bit is to extract the shebang, then run the command file against it (not sure if there'll be any quirks with doing this manually vs letting the shell do it for you).

[rfay]

I was wrong about this whole thing, the executable bit is required, and that's why DDEV sets it. Your evaluation of the need here is correct.

[stasadev]

Thank you!