pip should use the distro module: platform.linux_distribution() has been deprecated in Python 3.5

[vstinner]

• Pip version: development version
• Python version: 3.5
• Operating System: Fedora 24

Description:

"pip install PrettyTable" logs a PendingDeprecationWarning because platform.linux_distribution() has been deprecated in Python 3.5:

.../pip/download.py:93: PendingDeprecationWarning: dist() and linux_distribution() functions are deprecated in Python 3.5
  zip(["name", "version", "id"], platform.linux_distribution()),

I suggest to replace the function with the distro module:

• https://pypi.python.org/pypi/distro
• https://github.com/nir0s/distro

FYI platform.linux_distribution() and platform.dist() have been deprecated by https://bugs.python.org/issue1322

[AbdealiLoKo]

Would this imply that if pip is installed, distro will also be installed ?

Because I want to use distro in my setup.py and would not need to download it inside setup.py or use setup_requires for it if it's available because of pip.

[vstinner]

Would this imply that if pip is installed, distro will also be installed ?

No, I suggest to put it in pip/_vendor/ "hidden" package.

[nir0s]

That would be swell. LMK if I can help.

[xavfernandez]

Seems like a good idea, it would be good to avoid PendingDeprecationWarning on 3.6.
cc @dstufft @pfmoore

[pfmoore]

It's only a tiny module, so I don't see a big issue. As I don't use Linux, I don't have any view on whether distro is the "right" solution here - I don't know what options exist - so I'm OK with whatever the experts agree on.

[dstufft]

I've planned on doing that yes, I jsut hadn't gotten around to it yet.

[nir0s]

If you provide me with the information, I can submit the PR

[xavfernandez]

I've pushed #3906 hopefully I did not forget anything ?