Skip to content

[3.5] bpo-35411: Skip test_urllib2net FTP tests on Travis CI (GH-10907)#11874

Merged
larryhastings merged 2 commits intopython:3.5from
vstinner:travis_skip_ftp35
Feb 25, 2019
Merged

[3.5] bpo-35411: Skip test_urllib2net FTP tests on Travis CI (GH-10907)#11874
larryhastings merged 2 commits intopython:3.5from
vstinner:travis_skip_ftp35

Conversation

@vstinner
Copy link
Copy Markdown
Member

@vstinner vstinner commented Feb 15, 2019 •
edited by bedevere-bot
Loading

On Travis CI, FTP tests of test_urllib2net randomly fail with "425
Security: Bad IP connecting".

(cherry picked from commit c11b3b1)

https://bugs.python.org/issue35411

@vstinner
bpo-35411: Skip test_urllib2net FTP tests on Travis CI (GH-10907)
4a33135 
On Travis CI, FTP tests of test_urllib2net randomly fail with "425
Security: Bad IP connecting".

(cherry picked from commit c11b3b1)
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting merge labels Feb 15, 2019
@vstinner vstinner mentioned this pull request Feb 15, 2019
Merged
@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented Feb 15, 2019

@larryhastings, @ned-deily or @ambv: Can you please merge this fix to unblock PR #11869 security fix?

eamanu
eamanu approved these changes Feb 15, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vstinner vstinner mentioned this pull request Feb 25, 2019
Merged
larryhastings
larryhastings approved these changes Feb 25, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@larryhastings larryhastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented Feb 25, 2019

Good, Travis CI succeeded ;-)

@larryhastings larryhastings merged commit 8bcbc78 into python:3.5 Feb 25, 2019
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Feb 25, 2019

@larryhastings: Please replace # with GH- in the commit message next time. Thanks!

@larryhastings
Copy link
Copy Markdown
Contributor

larryhastings commented Feb 25, 2019

Thanks for the fix! Now I can merge the other stuff.

@vstinner vstinner deleted the travis_skip_ftp35 branch April 29, 2019 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larryhastings larryhastings larryhastings approved these changes

+1 more reviewer

@eamanu eamanu eamanu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner @bedevere-bot @larryhastings @eamanu @the-knights-who-say-ni