GH-89435: os.path should not be a frozen module#126924
Merged
FFY00 merged 1 commit intopython:mainfrom Nov 22, 2024
Merged
Conversation
Closed
FFY00
changed the title
Signed-off-by: Filipe Laíns <lains@riseup.net>
Member
Author
|
@ericsnowcurrently, whenever you have a moment to ACK this, it would be great. It shouldn't take a lot of time. |
ericsnowcurrently
approved these changes
Nov 22, 2024
Member
ericsnowcurrently
left a comment
ericsnowcurrently
left a comment
There was a problem hiding this comment.
LGTM
Thanks for working on this and sticking with it!
(I wish I had been more clear in a comment or something about why we froze os.path in the first place. Clearly we don't need to at this point. 😄)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As Eric mentioned in GH-29329, this workaround might not be needed anymore. The test suite does not seem to complain on my machine, so I think that may be the case, let's see if the CI complains. If there are no CI failures, then I think it should probably be okay to drop this workaround.