Skip to content

bpo-37849: IDLE: fix completion window positioning above line#15267

Merged
terryjreedy merged 4 commits intopython:masterfrom
taleinat:bpo-37849/idle-completion-window-position
Aug 14, 2019
Merged

bpo-37849: IDLE: fix completion window positioning above line#15267
terryjreedy merged 4 commits intopython:masterfrom
taleinat:bpo-37849/idle-completion-window-position

Conversation

@taleinat
Copy link
Copy Markdown
Contributor

@taleinat taleinat commented Aug 14, 2019 •
edited
Loading

This also adds a mechanism to avoid multiple, recursive invocations of the "<Configure>" event handler, required due to the added .update() call.

https://bugs.python.org/issue37849

@taleinat
bpo-37849: fix completion window positioning above line
b31fa48 
Added a mechanism to avoid multiple, recursive invocations of the
"<Configure>" event handler, required due to the added .update() call.
@taleinat taleinat added type-bug An unexpected behavior, bug, or error needs backport to 3.7 labels Aug 14, 2019
@taleinat taleinat requested a review from terryjreedy August 14, 2019 06:48
@terryjreedy
Copy link
Copy Markdown
Member

terryjreedy commented Aug 14, 2019

New news items go on top, with the fixed length divider line and 2 blank lines above and a blank line and the previous item below. As long as all are backported, all will backport without conflict in either the upper or lower 3-line context. In this case, there was a previous item to be added also.

For the first news addition after a final release, which requires a new header at least on that version, the lower context will be different on different versions. So I do the addition on separate PRs (master and manual backports as needed) attached to the current next-version NEWS issue (now bpo 34162 for 3.8). I also use that for corrections and batch additions.

@terryjreedy terryjreedy merged commit 71662dc into python:master Aug 14, 2019
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Aug 14, 2019

Thanks @taleinat for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 14, 2019
@taleinat @miss-islington
bpo-37849: IDLE: fix completion window positioning above line (python…
5432dd6 
…GH-15267)

(cherry picked from commit 71662dc)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Aug 14, 2019

GH-15282 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Aug 14, 2019

GH-15283 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 14, 2019
@taleinat @miss-islington
bpo-37849: IDLE: fix completion window positioning above line (python…
fccccab 
…GH-15267)

(cherry picked from commit 71662dc)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
miss-islington added a commit that referenced this pull request Aug 14, 2019
@miss-islington @taleinat
bpo-37849: IDLE: fix completion window positioning above line (GH-15267)
557802d 
(cherry picked from commit 71662dc)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
miss-islington added a commit that referenced this pull request Aug 14, 2019
@miss-islington @taleinat
bpo-37849: IDLE: fix completion window positioning above line (GH-15267)
88cce7b 
(cherry picked from commit 71662dc)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@taleinat @lisroach
bpo-37849: IDLE: fix completion window positioning above line (python…
08e4615 
…GH-15267)
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@taleinat @DinoV
bpo-37849: IDLE: fix completion window positioning above line (python…
26589e6 
…GH-15267)
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@taleinat @websurfer5
bpo-37849: IDLE: fix completion window positioning above line (python…
bf77e58 
…GH-15267)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy Awaiting requested review from terryjreedy

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@taleinat @terryjreedy @miss-islington @bedevere-bot @the-knights-who-say-ni