bpo-33694: Remove test_asyncio ProactorDatagramTransportTests#16288
bpo-33694: Remove test_asyncio ProactorDatagramTransportTests#16288vstinner merged 1 commit intopython:masterfrom vstinner:asyncio_fixme
Conversation
ProactorDatagramTransportTests tests are too close to the implementation.
|
Since my commit 79790bc, nobody came up with a better way to test this code, so I propose to simply remove it. On buildbots, when test_asyncio fails, it is re-run in verbose mode. If the overall job fails, a bot looks into buildot logs and copy them to the pull request which introduced the regression. Because of "... FIXME: bpo-33694: ..." messages, tons of pull requests have be associated to https://bugs.python.org/issue33694 whereas they are unrelated to asyncio... cc @pablogsal |
asvetlov
left a comment
There was a problem hiding this comment.
Good to me.
@1st1 hates mock based asyncio tests for the same reason, I agree with him.
These tests were important in making the first implementation of UDP proactor sockets; the tests helped me to figure out how the code actually works.
Now the tests are useless
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
I'm having trouble backporting to |
Yeah, me too. I hate tests which basically tests mock rather than testing the actual code. |
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
GH-16305 is a backport of this pull request to the 3.8 branch. |
|
ProactorDatagramTransportTests tests are too close to the
implementation.
https://bugs.python.org/issue33694