bpo-40334: Don't skip test_parser:test_trigger_memory_error#19744
Merged
pablogsal merged 1 commit intopython:masterfrom Apr 28, 2020
Merged
bpo-40334: Don't skip test_parser:test_trigger_memory_error#19744pablogsal merged 1 commit intopython:masterfrom
pablogsal merged 1 commit intopython:masterfrom
Conversation
This test has been changed to always use the old parser, so no need for it to be skipped.
gvanrossum
approved these changes
Apr 27, 2020
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
(Why doesn't pegen trigger? Because it goes up to 200?)
Member
Author
Yes, and that's because the tokenizer enforces that restriction. The old parser was throwing a |
lysnikolaou
changed the title
pablogsal
approved these changes
Apr 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test has been changed to always use the old parser, so no need
for it to be skipped.
https://bugs.python.org/issue40334