bpo-43843: libregrtest uses threading.excepthook#25400
Merged
vstinner merged 4 commits intopython:masterfrom Apr 16, 2021
vstinner:regrtest_threading_excepthook
Merged
bpo-43843: libregrtest uses threading.excepthook#25400vstinner merged 4 commits intopython:masterfrom vstinner:regrtest_threading_excepthook
vstinner merged 4 commits intopython:masterfrom
vstinner:regrtest_threading_excepthook
Conversation
test.libregrtest now marks a test as ENV_CHANGED (altered the execution environment) if a thread raises an exception but does not catch it. It sets a hook on threading.excepthook. Use --fail-env-changed option to mark the test as failed.
Member
Author
|
I expected that many tests will start to fail when run using --fail-env-changed and it would be better for fix them first. Once CI jobs run on the PR will pass, I will use the buildbot label to test it on buildbots. |
libregrtest hook now logs the exception type
Member
Author
|
Travis CI: |
libregrtest regrtest_unraisable_hook() and regrtest_threading_excepthook() now explicitly flush sys.stdout, sys.stderr and sys.__stderr__.
Member
Author
|
Azure Pipelines PR: test_logging and test_ssl failed on macOS. The logging issue is https://bugs.python.org/issue43842 The test_ssl failure is unrelated to this PR, I already saw in in other PRs. => I created https://bugs.python.org/issue43855 to track it Azure Pipelines PR: test_asyncio failed on Windows PR win32, this one is unrelated by this PR and is known: |
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test.libregrtest now marks a test as ENV_CHANGED (altered the
execution environment) if a thread raises an exception but does not
catch it. It sets a hook on threading.excepthook. Use
--fail-env-changed option to mark the test as failed.
https://bugs.python.org/issue43843