bpo-41611: IDLE: fix freezing on completion on macOS#26400
bpo-41611: IDLE: fix freezing on completion on macOS#26400taleinat merged 2 commits intopython:mainfrom
Conversation
Signed-off-by: Tal Einat <532281+taleinat@users.noreply.github.com>
Signed-off-by: Tal Einat <532281+taleinat@users.noreply.github.com>
|
Fix works on my system. |
Thanks @E-Paine! |
|
Can we add a test for this, to ensure it doesn't occur in the future? Edit: is that possible? |
Possible but hard, and we don't have the infrastructure for it yet. We'd need a way to run IDLE in a sub-process, send events, inspect what happens, and close it cleanly. We could add a specific h-test for this, but IMO that wouldn't be worth it. |
|
LGTM, too. It may still be possible to get this into the delayed 3.10.0b2 if it is merged to 3.10 quickly. |
Ooh yes, let's! Merging now. |
|
Thanks @taleinat for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9. |
(cherry picked from commit abc4bd5) Co-authored-by: Tal Einat <532281+taleinat@users.noreply.github.com>
|
GH-26401 is a backport of this pull request to the 3.10 branch. |
(cherry picked from commit abc4bd5) Co-authored-by: Tal Einat <532281+taleinat@users.noreply.github.com>
|
GH-26402 is a backport of this pull request to the 3.9 branch. |
|
I verified the fix on installed .0b1 on Mac by #ing the line. Both Tab and .[popup] work great. Thank you Tal and others for fixing this and getting it, I hope, into .0b2!!! The last line of autocomplete_w.py: @E-Paine If you want to try this, use the calltip h-test as a model. (and that one should be extended if possible to test force-open). |
https://bugs.python.org/issue41611