bpo-46608: exclude marshalled-frozen data if deep-freezing to save 300 KB space #31074
bpo-46608: exclude marshalled-frozen data if deep-freezing to save 300 KB space #31074miss-islington merged 17 commits intopython:mainfrom
Conversation
|
I added |
|
Hopefully @ericsnowcurrently can review this -- he should know about use cases where this might break. |
ericsnowcurrently
left a comment
There was a problem hiding this comment.
Other than one small thing, this is looking good. (The PR is marked as "Draft". Are you planning on changing anything?)
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Thanks for making the requested changes! @ericsnowcurrently: please review the changes made to this pull request. |
ericsnowcurrently
left a comment
There was a problem hiding this comment.
With a few small tweaks, this is ready to go.
Misc/NEWS.d/next/Build/2022-02-02-11-26-46.bpo-46608.cXH9po.rst
Outdated
Show resolved
Hide resolved
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
ericsnowcurrently
left a comment
There was a problem hiding this comment.
LGTM
Thanks for working on this, Kumar!
|
@kumaraditya303: Status check is done, and it's a failure ❌ . |
2 similar comments
|
@kumaraditya303: Status check is done, and it's a failure ❌ . |
|
@kumaraditya303: Status check is done, and it's a failure ❌ . |
gvanrossum
left a comment
There was a problem hiding this comment.
I don't follow the logic of the argument parsing, and I have one small grammar tweak. Otherwise LGTM!
|
@kumaraditya303: Status check is done, and it's a success ✅ . |
This reduces the size of the data segment by 300 KB of the executable because if the modules are deep-frozen then the marshalled frozen data just wastes space. This was inspired by comment by @gvanrossum in #29118 (comment). Note: There is a new option
--deepfreeze-onlyinfreeze_modules.pyto change this behavior, it is on be default to save disk space.https://bugs.python.org/issue46608
Automerge-Triggered-By: GH:ericsnowcurrently