Merged
Conversation
benjaminp
force-pushed
the
benjamin-unicode-11
branch
2 times, most recently
from
2a16b33 to
ee429da
Compare
Also, standardize indentation of generated tables.
benjaminp
force-pushed
the
benjamin-unicode-11
branch
from
ee429da to
49b05a8
Compare
matrixise
reviewed
Jun 6, 2018
| return | ||
| (0x3400 <= code && code <= 0x4DB5) || /* CJK Ideograph Extension A */ | ||
| (0x4E00 <= code && code <= 0x9FEA) || /* CJK Ideograph */ | ||
| (0x4E00 <= code && code <= 0x9FEF) || /* CJK Ideograph */ |
Member
There was a problem hiding this comment.
Hi @benjaminp, why did you change the value? just for my own info, I am interested.
Thank you
Member
There was a problem hiding this comment.
Current version: https://www.unicode.org/Public/UCD/latest/ucd/PropList.txt
Old version: https://www.unicode.org/Public/10.0.0/ucd/PropList.txt
ctrl+f for CJK
matrixise
approved these changes
Jun 6, 2018
| return | ||
| (0x3400 <= code && code <= 0x4DB5) || /* CJK Ideograph Extension A */ | ||
| (0x4E00 <= code && code <= 0x9FEA) || /* CJK Ideograph */ | ||
| (0x4E00 <= code && code <= 0x9FEF) || /* CJK Ideograph */ |
Contributor
|
Thanks @benjaminp for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-7470 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 7, 2018
Also, standardize indentation of generated tables. (cherry picked from commit 7c69c1c) Co-authored-by: Benjamin Peterson <benjamin@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue33778