PEP 634: Change so __match_args__ must be a tuple#1909
Merged
gvanrossum merged 2 commits intomasterfrom Apr 5, 2021
Merged
Conversation
willingc
approved these changes
Apr 4, 2021
Contributor
|
@gvanrossum It looks like line 498 has an extra "`" around match_args |
Member
Author
|
@brandtbucher -- How do you feel about implementing this change? |
Member
|
@gvanrossum No problem, I'll have something up later today. |
brandtbucher
approved these changes
Apr 5, 2021
Member
Author
|
I think this is now sufficiently non-controversial that I'm just changing the PEP and we'll update the implementation ASAP (not sure if it will make 3.10a7, if not then definitely b1). |
gvanrossum
pushed a commit
to python/cpython
that referenced
this pull request
Apr 6, 2021
See: - python/peps#1909 (__match_args__ must be a tuple) - python/peps#1908 (allow keyword patterns for int(x) etc.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was discussed on python-dev in the thread
https://mail.python.org/archives/list/python-dev@python.org/thread/YYIT3QXMLPNLXQAQ5BCXE4LLJ57EE7JV/#YYIT3QXMLPNLXQAQ5BCXE4LLJ57EE7JV
I don't think anyone disagrees that it's better if
__match_args__is required to be a tuple.