Issue #21: Avoid C++ keyword module

[erlend-aasland]

Rename module variable/argument names as mod.

Fixes #21

[corona10]

LGTM with easy solution but let's wait @vstinner 's review

[vstinner]

Is it possible to detect the error using a C++ compiler warning to prevent adding new ones? The C++ compatibility is tested in tests/.

[erlend-aasland]

Is it possible to detect the error using a C++ compiler warning to prevent adding new ones? The C++ compatibility is tested in tests/.

Good point. I'll add a test.

[vstinner]

I guess that this PR is related to: https://bugs.python.org/issue39355

I don't get any warning:

$ cat x.cc 
int main() { int module = 1; return module; }
$ g++ -std=c++20 -Wall -Wextra x.cc -o x
# no warning

[vstinner]

I changed my mind. Python.h has the issue, so until Python will be fixed ( https://bugs.python.org/issue39355 https://bugs.python.org/issue39355 ) we cannot test it in pythoncapi_compat.h which includes Python.h. I don't want to add a test using a regex which would emit false alarm if the word "module" is used in a comment.

[vstinner]

Thanks, I merged your fix!

[erlend-aasland]

I changed my mind. Python.h has the issue, so until Python will be fixed ( https://bugs.python.org/issue39355 https://bugs.python.org/issue39355 ) we cannot test it in pythoncapi_compat.h which includes Python.h. I don't want to add a test using a regex which would emit false alarm if the word "module" is used in a comment.

Makes sense!