Rewrite run_parser* functions to always return a mod_ty#17
Merged
lysnikolaou merged 6 commits intopegenfrom Mar 24, 2020
Merged
Rewrite run_parser* functions to always return a mod_ty#17lysnikolaou merged 6 commits intopegenfrom
lysnikolaou merged 6 commits intopegenfrom
Conversation
* The caller is responsible for transforming the mod_ty to
a code object or an AST object
gvanrossum
reviewed
Mar 23, 2020
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
I still think we should switch EXTENSION_SUFFIX to be much smaller and move most of that code to a separate file.
Member
Author
Okay, a separate PR is fine! |
gvanrossum
reviewed
Mar 23, 2020
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
Better, but I'd still like to see if we can easily drop the filename_ob parameters.
Member
Author
Just pushed a fix for this. |
Member
Author
Yes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15.