PHP Deprecated: Creation of dynamic property cli\arguments\HelpScreen::$_flagMax is deprecated

[kodie]

Bug Report

• Yes, I reviewed the contribution guidelines.
• Yes, more specifically, I reviewed the guidelines on how to write clear bug reports.

Describe the current, buggy behavior

While running the "arguments" example on PHP v8.2.1 and passing the "help" option, the following errors occur:

PHP Deprecated:  Creation of dynamic property cli\arguments\HelpScreen::$_flagMax is deprecated in /Users/kodiegrantham/www/misc/fss-cli/vendor/wp-cli/php-cli-tools/lib/cli/arguments/HelpScreen.php on line 43

Deprecated: Creation of dynamic property cli\arguments\HelpScreen::$_flagMax is deprecated in /Users/kodiegrantham/www/misc/fss-cli/vendor/wp-cli/php-cli-tools/lib/cli/arguments/HelpScreen.php on line 43
PHP Deprecated:  Creation of dynamic property cli\arguments\HelpScreen::$_optionMax is deprecated in /Users/kodiegrantham/www/misc/fss-cli/vendor/wp-cli/php-cli-tools/lib/cli/arguments/HelpScreen.php on line 50

Deprecated: Creation of dynamic property cli\arguments\HelpScreen::$_optionMax is deprecated in /Users/kodiegrantham/www/misc/fss-cli/vendor/wp-cli/php-cli-tools/lib/cli/arguments/HelpScreen.php on line 50

These errors don't show up on PHP v8.0.30

Describe how other contributors can replicate this bug

• cd php-cli-tools/examples
• ./arguments help

[swissspidy]

Looks like a simple oversight where the property has the wrong name here, it should be flagMax:

php-cli-tools/lib/cli/arguments/HelpScreen.php

Line 22 in 8ffd0cf

protected $_maxFlag = 0;

Ditto for optionMax / maxOption:

php-cli-tools/lib/cli/arguments/HelpScreen.php

Line 24 in 8ffd0cf

protected $_maxOption = 0;

Would you be up for submitting a PR that renames them?

[kodie]

@swissspidy PR made!