Adopt proposed API for test debug restart #23752

Activity

1. Karthik Nadig (karthiknadig)

   added

   feature-requestRequest for new features or functionalityRequest for new features or functionality

   needs PRReady to be worked onReady to be worked on

   on Jul 8, 2024
2. Karthik Nadig (karthiknadig)

   added this to the July 2024 milestone on Jul 8, 2024
3. Karthik Nadig (karthiknadig)

   assigned

   Eleanor Boyd (eleanorjboyd)

   on Jul 8, 2024
4. Karthik Nadig (karthiknadig)

   modified the milestones: July 2024, August 2024 on Jul 22, 2024
5. eleanorjboyd commented on Jul 25, 2024

   

   Eleanor Boyd (eleanorjboyd)

   on Jul 25, 2024

   More actions

   here is the core issue we are using to make these changes: microsoft/vscode#214486
6. eleanorjboyd commented on Jul 25, 2024

   

   Eleanor Boyd (eleanorjboyd)

   on Jul 25, 2024

   Last edited by eleanorjboyd

   More actions

   Potential bug:

   It seems that onTerminateDebugSession gets called for all runInstances known to the debugger from the reload state. See logs I recorded with these random distinct numbers to differentiate the run instances. You can see my first runInstance #426 is created then canceled (this is bc I have reloaded which we talked about was the right behavior). Then the reload spawns a new process right after (runInstance #721) which I never cancel or anything as the user but you can see onDidTerminateDebugSession is called on it either way. What is also interesting is the other runInstance numbers called for onDidTerminateDebugSession were from a previous run I had made when trying this same process before (#530 and #994). So those instances should be completely gone but they come back and get called again. Once I reload my vscode window previous instances disappear but as long as I am in a session, only instances are called again. From this it seems like onDidTerminateDebugSession is being called too many times and specifically is called too early for my regenerated instance on reload which causes a bug.

   Logs from Run
   [user: click debug]
   created run instance Running Tests for Workspace(s):random: 426
   launch debugger Running Tests for Workspace(s):random: 426
   [user: click reload]
   onCancellationRequested Running Tests for Workspace(s):random: 426
   end run instance Running Tests for Workspace(s):random: 426
   created run instance Running Tests for Workspace(s):random: 721
   launch debugger Running Tests for Workspace(s):random: 721
   info 15:44:48.684: Jupyter Extension: Ending debug session
   onDidTerminateDebugSession : Running Tests for Workspace(s): random: 994
   onDidTerminateDebugSession : Running Tests for Workspace(s): random: 530
   onDidTerminateDebugSession : Running Tests for Workspace(s): random: 530 resolve
   onDidTerminateDebugSession : Running Tests for Workspace(s): random: 426
   onDidTerminateDebugSession : Running Tests for Workspace(s): random: 721
   onDidTerminateDebugSession : Running Tests for Workspace(s): random: 721 resolve
   end run instance Running Tests for Workspace(s): random: 721
   {user screen is now on a new debug instance with the breakpoint hit waiting for user input}
7. Eleanor Boyd (eleanorjboyd)

   added

   area-testing

   on Jul 29, 2024
8. Eleanor Boyd (eleanorjboyd)

   closed this as completedin #23891on Aug 6, 2024
9. Eleanor Boyd (eleanorjboyd)

   closed this as completedin 1c8d20eon Aug 6, 2024
10. Eleanor Boyd (eleanorjboyd)

    added a commit that references this issue on Aug 6, 2024

    Debug test session proposed (microsoft#23891)

    ...

    1c8d20e
11. eleanorjboyd commented on Aug 27, 2024

    

    Eleanor Boyd (eleanorjboyd)

    on Aug 27, 2024

    More actions

    this was a tracking issue- the verification should be done on related bugs like: #20520
12. Eleanor Boyd (eleanorjboyd)

    added

    verifiedVerification succeededVerification succeeded

    on Aug 27, 2024
13. github-actions

    locked as resolved and limited conversation to collaborators on Sep 27, 2024