Repository navigation
Improve message for config shuffle-salts result #173
Description
Bug Report
- [✓] Yes, I reviewed the contribution guidelines.
- [✓] Yes, more specifically, I reviewed the guidelines on how to write clear bug reports.
Describe the current, buggy behavior
We could improve message of wp config shuffle-salts command when key does not exist.
wp config shuffle-salts WP_CACHE_KEY_SALT
Warning: Could not shuffle the unknown key 'WP_CACHE_KEY_SALT'.
Success: Shuffled the salt keys.
Activity
danielbachhuber commentedon Feb 16, 2024
@ernilambar To clarify, what would be your suggested improvement?
ernilambar commentedon Feb 18, 2024
May be we can utilize
report_batch_operation_results():wp config shuffle-salts WP_CACHE_KEY_SALTOR
wp config shuffle-salts WP_CACHE_KEY_SALT NONCE_SALTOR
danielbachhuber commentedon Feb 18, 2024
@ernilambar I'm amenable to using
report_batch_operation_results().I would call them "salts" instead of "configs", though.
ernilambar commentedon Feb 18, 2024
@danielbachhuber Should it be
Error: Only shuffled 1 of 2 salts.orSuccess: Shuffled 1 of 2 salts (1 skipped).?danielbachhuber commentedon Feb 18, 2024
@ernilambar The latter, I think
ernilambar commentedon Feb 19, 2024
@danielbachhuber I have noticed
contributor-daytag in several issues. Does that mean issues should be kept for Contributor Day to be fixed?danielbachhuber commentedon Feb 19, 2024
@ernilambar No, only that it's a good issue for contributor day if it's still open at that time.