Include a projects children in an alert rules limitations - #2013
Conversation
Currently, when creating a limited alert rule you need to select every single version of a project. This does not work well for projects which create new versions regularly. By automatically subscribing every child of a project to a notification rule, it is simpler to limit all existing or every future version of a project to a notification rule. Signed-off-by: RBickert <rbt@mm-software.com>
Added tests in `NotificationRouterTest.java` which cover the cases of a subscribed parent project with an affected child and an inactive affected child. Signed-off-by: RBickert <rbt@mm-software.com>
Signed-off-by: RBickert <rbt@mm-software.com>
Signed-off-by: RBickert <rbt@mm-software.com>
…cluding-all-existing-or-future-versions Limit alert rules to project including all existing or future versions
|
|
|
Hey @nscuro, I'm not quite sure why this build failed. The workflow runs successfully in our repository and I don't think that I've changed anything which would throw a |
|
No worries @rbt-mm, it's just GitHub being GitHub again. When trying to download the frontend ZIP, the GitHub API returned a 503, causing the build to fail. I don't think contributors can manually trigger workflows, but you could always contact us maintainers (as you did), or push an empty commit to trigger another workflow execution. |
nscuro
left a comment
There was a problem hiding this comment.
Thanks for the PR @rbt-mm!
Overall this looks good to me. But I was wondering whether this should be an option that users can opt-in to / opt-out of? Just because there is a hierarchy, it doesn't necessarily mean I'm interested in all notifications affecting child projects.
Yes that's something I was also thinking about, but for simplicity decided against it for the first attempt. But the question is:
If you think option 1) is enough we can easily do that, for 2) we would have to figure out how and will take some more time. |
|
I think option 1 should suffice. |
…roject-including-all-existing-or-future-versions
Added new attribute to 'NotificationRule' which optionally includes every active child of the subscribed projects in the notification rule. Signed-off-by: RBickert <rbt@mm-software.com>
…o-project-including-all-existing-or-future-versions
…ing-or-future-versions' into rbt-limit-alert-rules-to-project-including-all-existing-or-future-versions
…cluding-all-existing-or-future-versions Optionally include a projects children in an alert rules limitations
#1608
Currently, when creating a limited alert rule you need to select every single version of a project. This does not work well for projects which create new versions regularly.
By automatically including every active child of a project to a notification rule, it is simpler to limit all existing or every future version of a project to a notification rule.
Frontend PR
Signed-off-by: RBickert rbt@mm-software.com