Skip to content

Remove unnecessary hz-scrollbar on expanded rows - #249

Merged
nscuro merged 1 commit into
DependencyTrack:masterfrom
tmehnert:remove-unnecessary-horizontal-scrollbar
Sep 22, 2022
Merged

Remove unnecessary hz-scrollbar on expanded rows#249
nscuro merged 1 commit into
DependencyTrack:masterfrom
tmehnert:remove-unnecessary-horizontal-scrollbar

Conversation

@tmehnert

@tmehnert tmehnert commented Sep 18, 2022

Copy link
Copy Markdown
Contributor

This effectively reduce the width of an expanded-row by 2 pixels to remove the scrollbar, when it is not necessary. It turns out that border-collapse: collapse; on the table causing the scrollbars to be shown. Because of setting this attribute to seperate will change the appearance, i adjusted the margin of the expanded-rows instead. The commit will overwrite the margin-right: -15px, which is set by the row class.

Tested on Chrome and Firefox. Please someone test it on Safari.

Fixes #248

Signed-off-by: Torsten Mehnert <torsten.mhn@gmail.com>

@nscuro nscuro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that @tmehnert, attention to detail truly matters!

Tested on Safari BTW, it works there as well.

@nscuro
nscuro merged commit 65f1850 into DependencyTrack:master Sep 22, 2022
@tmehnert
tmehnert deleted the remove-unnecessary-horizontal-scrollbar branch September 22, 2022 23:45
yuwwx pushed a commit to yuwwx/dependency-track-frontend that referenced this pull request Jun 2, 2026
…t/github_actions/docker/build-push-action-6.15.0
heyiamwahab236 pushed a commit to tecan/frontend_custom that referenced this pull request Jun 17, 2026
…ry-horizontal-scrollbar

Remove unnecessary hz-scrollbar on expanded rows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unnecessary horizontal scrollbar shown in expanded rows

2 participants