Skip to content

Remove dependency on vue-showdown - #300

Merged
nscuro merged 2 commits into
DependencyTrack:4.6.xfrom
nscuro:replace-vue-showdown
Oct 24, 2022
Merged

Remove dependency on vue-showdown#300
nscuro merged 2 commits into
DependencyTrack:4.6.xfrom
nscuro:replace-vue-showdown

Conversation

@nscuro

@nscuro nscuro commented Oct 24, 2022

Copy link
Copy Markdown
Member

Depend on Showdown directly instead, cutting out the middleman.

Additionally:

  • Escape HTML outside of Markdown code blocks, in order to prevent unintended rendering of HTML elements (e.g. the textarea in CVE-2022-25869)
  • Always run Showdown output through DOMPurify

Signed-off-by: nscuro nscuro@protonmail.com

Depend on Showdown directly instead, cutting out the middleman.

Additionally:

* Escape HTML outside of Markdown code blocks, in order to prevent unintended rendering of HTML elements (e.g. the `textarea` in CVE-2022-25869)
* Always run Showdown output through DOMPurify

Signed-off-by: nscuro <nscuro@protonmail.com>
@nscuro nscuro added this to the 4.6.1 milestone Oct 24, 2022
Comment thread package.json
Appears to only be necessary for the build with Node 14.

npm/cli#2610
Signed-off-by: nscuro <nscuro@protonmail.com>
@nscuro
nscuro merged commit 0cfdabd into DependencyTrack:4.6.x Oct 24, 2022
@nscuro
nscuro deleted the replace-vue-showdown branch October 24, 2022 11:26
yuwwx pushed a commit to yuwwx/dependency-track-frontend that referenced this pull request Jun 2, 2026
…t/docker/docker/nginxinc/nginx-unprivileged-79a788b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant