Skip to content

ACL: Make project names clickable - #320

Merged
nscuro merged 1 commit into
DependencyTrack:masterfrom
valentijnscholten:acl-projects-clickable
Nov 6, 2022
Merged

ACL: Make project names clickable#320
nscuro merged 1 commit into
DependencyTrack:masterfrom
valentijnscholten:acl-projects-clickable

Conversation

@valentijnscholten

@valentijnscholten valentijnscholten commented Nov 5, 2022

Copy link
Copy Markdown
Contributor

When managing ACLs, the projects assigned to teams has a non-clickable name.
It thought it might be handy to make them clickable.
I did encode the url for XSS, but I am not sure this is needed when letting Vue take care of rendering the template.
(And it would be hard to embed a XSS payload in a uuid generated by the database)

2022-11-05 19_30_38-Dependency-Track - Administration

Signed-off-by: Valentijn Scholten <valentijnscholten@gmail.com>
@nscuro

nscuro commented Nov 5, 2022

Copy link
Copy Markdown
Member

I did encode the url for XSS, but I am not sure this is needed when letting Vue take care of rendering the template.

According to the Vue documentation, values included via attribute binding (e.g. :href="this.href") are also encoded: https://vuejs.org/guide/best-practices/security.html#what-vue-does-to-protect-you

So you don't have to do it here.

@nscuro nscuro added this to the 4.7 milestone Nov 6, 2022
@nscuro nscuro added the enhancement New feature or request label Nov 6, 2022
@nscuro
nscuro merged commit 77eb9ae into DependencyTrack:master Nov 6, 2022
yuwwx pushed a commit to yuwwx/dependency-track-frontend that referenced this pull request Jun 2, 2026
…t/github_actions/actions/download-artifact-5.0.0
heyiamwahab236 pushed a commit to tecan/frontend_custom that referenced this pull request Jun 17, 2026
…jects-clickable

ACL: Make project names clickable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants